Matthieu Gallien [Fri, 24 Jan 2025 08:15:16 +0000 (09:15 +0100)]
Merge pull request #7782 from nextcloud/feature/client-alma8
modify AppImage build script to work with an EL8 base
Matthieu Gallien [Thu, 23 Jan 2025 19:42:35 +0000 (20:42 +0100)]
use latest appimage build docker image
see https://github.com/nextcloud/docker-ci/pkgs/container/continuous-integration-client-appimage-qt6/
342431972?tag=client-appimage-el8-6.8.1-2
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Jyrki Gadinger [Thu, 23 Jan 2025 15:02:47 +0000 (16:02 +0100)]
update AppImage build comment text
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Matthieu Gallien [Thu, 23 Jan 2025 14:50:10 +0000 (15:50 +0100)]
update the drone signature
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Jyrki Gadinger [Thu, 23 Jan 2025 13:55:36 +0000 (14:55 +0100)]
replace drone PR appimage setup with GitHub Actions
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Jyrki Gadinger [Thu, 23 Jan 2025 11:31:08 +0000 (12:31 +0100)]
start using the EL8 image for building the appimage
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Jyrki Gadinger [Wed, 22 Jan 2025 14:30:23 +0000 (15:30 +0100)]
gitignore: add .cache and *.AppImage
.cache is used by clangd on my setup; built AppImages also shouldn't be
part of the repo
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Jyrki Gadinger [Wed, 22 Jan 2025 12:55:49 +0000 (13:55 +0100)]
modify appimage build script to work with an EL8 base
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Nextcloud bot [Fri, 24 Jan 2025 02:57:08 +0000 (02:57 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Thu, 23 Jan 2025 19:45:41 +0000 (20:45 +0100)]
Merge pull request #7718 from Diff-fusion/improve-log-speed
Log path strings directly instead of accumulating
Felix [Wed, 8 Jan 2025 12:45:41 +0000 (13:45 +0100)]
Check if discovery paths are empty before logging
Signed-off-by: Felix <felix-git@0xf.eu>
Felix [Sat, 4 Jan 2025 15:06:03 +0000 (16:06 +0100)]
Log path strings directly instead of accumulating
Signed-off-by: Felix <felix-git@0xf.eu>
Matthieu Gallien [Thu, 23 Jan 2025 11:13:13 +0000 (12:13 +0100)]
Merge pull request #7780 from nextcloud/feature/cleanDeprecatedHashAlgorithm
switch client side encryption to use sha256 hash algorithm
Matthieu Gallien [Wed, 22 Jan 2025 09:51:13 +0000 (10:51 +0100)]
switch client side encryption to use sha256 hash algorithm
Close #5989
only support sha1 for depreceted read-only usage
use sha256 for new encrypted write operations
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Thu, 23 Jan 2025 02:59:03 +0000 (02:59 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Thu, 23 Jan 2025 02:42:03 +0000 (03:42 +0100)]
Merge pull request #7772 from nextcloud/feature/capabilities-chunk-size-server
sync: Respect maximum chunk size provided in server capabilities
Claudio Cambra [Mon, 20 Jan 2025 09:56:52 +0000 (17:56 +0800)]
Apply max concurrent chunk uploads retrieved from server capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 09:56:28 +0000 (17:56 +0800)]
Expose maxConcurrentChunkUploads from Capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 09:51:55 +0000 (17:51 +0800)]
Remove overrideServerChunkSize config entry
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 09:49:12 +0000 (17:49 +0800)]
Actually call overrideServerChunkSize
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 09:48:56 +0000 (17:48 +0800)]
Do not apply max capabilities chunk size as min chunk size too
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 09:26:48 +0000 (17:26 +0800)]
Fix capsMaxChunkSize comparison
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 09:26:23 +0000 (17:26 +0800)]
Remove extraneous parenthesis
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 09:24:56 +0000 (17:24 +0800)]
Fix naming for overrideSercerChunkSize constexpr
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 03:59:27 +0000 (11:59 +0800)]
Add config entry to override server chunk size
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 03:55:33 +0000 (11:55 +0800)]
Enforce chunk size provided by server capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 02:34:17 +0000 (10:34 +0800)]
Override config chunk sizing values with max chunk size retrieved from capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 20 Jan 2025 02:33:06 +0000 (10:33 +0800)]
Add maxChunkSize getter function to get chunked upload max size from capabilities
This will be added with NC31
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Jyrki Gadinger [Wed, 22 Jan 2025 15:04:57 +0000 (16:04 +0100)]
Merge pull request #7754 from nextcloud/Rello-patch-1
Make Brander QT selection dynamic
Rello [Wed, 22 Jan 2025 12:15:12 +0000 (13:15 +0100)]
Update craftmaster.ini
Co-authored-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Rello [Wed, 15 Jan 2025 12:30:02 +0000 (13:30 +0100)]
Update VERSION.cmake
Signed-off-by: Rello <Rello@users.noreply.github.com>
Rello [Wed, 15 Jan 2025 11:35:57 +0000 (12:35 +0100)]
Update craftmaster.ini
Signed-off-by: Rello <Rello@users.noreply.github.com>
Matthieu Gallien [Wed, 22 Jan 2025 13:02:16 +0000 (14:02 +0100)]
Merge pull request #7781 from nextcloud/bugfix/readOnlyClassicalSyncLnkShortcutsWindows
fix the if check for invalid virtual LNK files
Matthieu Gallien [Wed, 22 Jan 2025 11:31:04 +0000 (12:31 +0100)]
fix the if check for invalid virtual LNK files
should ensure we fix the DB metadata of LNK windows shortcuts with
virtual files type
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 22 Jan 2025 10:46:44 +0000 (11:46 +0100)]
Merge pull request #7779 from nextcloud/bugfix/readOnlyClassicalSyncLnkShortcutsWindows
Bugfix/read only classical sync lnk shortcuts windows
Matthieu Gallien [Tue, 21 Jan 2025 14:35:57 +0000 (15:35 +0100)]
update metadata when a file item has wrong type in DB
should help fixing the type of windows shortcuts in DB that were wrongly
set as virtual files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 20 Jan 2025 16:10:09 +0000 (17:10 +0100)]
add an assert to ensure we do not use virtual file types with no VFS
if VFS mode is off, we should nto be using any virtual file types
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 20 Jan 2025 16:05:56 +0000 (17:05 +0100)]
handle LNK virtual files only when VFS mode is not off
should ensure lnk widnows shortcut files are not mistakenly handled as
virtual files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 22 Jan 2025 10:17:27 +0000 (11:17 +0100)]
Merge pull request #7769 from nextcloud/perf/color-conversion
Avoid converting string to color
Carl Schwan [Fri, 17 Jan 2025 14:10:18 +0000 (15:10 +0100)]
Avoid converting string to color
Use hex directly
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Nextcloud bot [Wed, 22 Jan 2025 03:00:23 +0000 (03:00 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Rello [Tue, 21 Jan 2025 12:33:09 +0000 (13:33 +0100)]
Update feature.md
Signed-off-by: Rello <Rello@users.noreply.github.com>
Matthieu Gallien [Tue, 21 Jan 2025 09:05:32 +0000 (10:05 +0100)]
Merge pull request #7774 from nextcloud/bugfix/addMissingDocImages
add some missing doc images in a valid path
Matthieu Gallien [Mon, 20 Jan 2025 14:38:33 +0000 (15:38 +0100)]
add some missing doc images in a valid path
we cannot use doc/images/building folder name due to some gitignore
rules
so let's rename it to doc/images/dev
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Tue, 21 Jan 2025 02:58:25 +0000 (02:58 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 20 Jan 2025 09:38:25 +0000 (10:38 +0100)]
Merge pull request #7773 from nextcloud/bugfix/updateLegalNotice
update legal notice copyright years for Nextcloud
Matthieu Gallien [Mon, 20 Jan 2025 07:50:36 +0000 (08:50 +0100)]
update legal notice copyright years for Nextcloud
Close #7767
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Sun, 19 Jan 2025 03:01:41 +0000 (03:01 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Carl Schwan [Sat, 18 Jan 2025 15:04:14 +0000 (16:04 +0100)]
Merge pull request #7770 from nextcloud/ui/menuseparator
Use normal MenuSeparator instead of custom code
Carl Schwan [Fri, 17 Jan 2025 14:30:57 +0000 (15:30 +0100)]
Use normal MenuSeparator instead of custom code
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Nextcloud bot [Sat, 18 Jan 2025 02:57:26 +0000 (02:57 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Fri, 17 Jan 2025 07:02:00 +0000 (15:02 +0800)]
Merge pull request #7766 from nextcloud/feature/gh-issue-types-templates
github: Implement issue types in issue templates
Claudio Cambra [Fri, 17 Jan 2025 05:39:53 +0000 (13:39 +0800)]
github: Add "Enhancement" issue type to feature request template
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 17 Jan 2025 05:39:31 +0000 (13:39 +0800)]
github: Add "Bug" issue type to BUG_REPORT template
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 17 Jan 2025 02:56:55 +0000 (02:56 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Thu, 16 Jan 2025 02:57:18 +0000 (02:57 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Jyrki Gadinger [Wed, 15 Jan 2025 15:11:12 +0000 (16:11 +0100)]
Merge pull request #7735 from nextcloud/bugfix/client-window-resize-on-scale-change
fix window resize on DPI changes
Jyrki Gadinger [Thu, 9 Jan 2025 10:44:56 +0000 (11:44 +0100)]
fix window resize on DPI changes
This commit fixes #7678 and likely fixes #7447 too. On Windows, when
the screen is changed to one with a different scaling setting the window
is being incorrectly resized. This can be worked around by storing the
window's size before moving it to a different screen, and then resizing
the window again.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Matthieu Gallien [Wed, 15 Jan 2025 11:06:32 +0000 (12:06 +0100)]
Merge pull request #7741 from nextcloud/bugfix/all-paused-macos-vfs
gui/tray: Fix sync state icon showing paused state when using macOS VFS with no standard sync folders
Claudio Cambra [Fri, 10 Jan 2025 06:18:14 +0000 (14:18 +0800)]
Set allPaused as false if we have available FileProvider domains with macOS VFS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Wed, 15 Jan 2025 10:27:07 +0000 (11:27 +0100)]
Merge pull request #7750 from nextcloud/feature/sparkle-2
updater: Upgrade to Sparkle 2
Claudio Cambra [Tue, 14 Jan 2025 05:44:38 +0000 (13:44 +0800)]
updater: Provide feedURL via non-deprecated delegate method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 14 Jan 2025 05:43:58 +0000 (13:43 +0800)]
mac-crafter: Apply code-signing procedure on Sparkle as recommended by Sparkle docs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 14 Jan 2025 05:03:57 +0000 (13:03 +0800)]
updater: Refactor NCSparkleUpdaterDelegate to conform to SPUUpdaterDelegate
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 14 Jan 2025 05:02:00 +0000 (13:02 +0800)]
updater: Replace SUUpdater with SPUStandardUpdaterController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 14 Jan 2025 04:58:38 +0000 (12:58 +0800)]
mac-crafter: Update Sparkle version to 2.6.4
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Wed, 15 Jan 2025 02:57:53 +0000 (02:57 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Tue, 14 Jan 2025 01:38:12 +0000 (01:38 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 13 Jan 2025 16:18:26 +0000 (17:18 +0100)]
Merge pull request #7737 from nextcloud/feature/improveLoginFlowV2Dialog
update runwizard introduction screen
Ankur Bavisa [Thu, 6 Jul 2023 13:05:14 +0000 (18:35 +0530)]
update runwizard introduction screen
Signed-off-by: Ankur Bavisa <Ankur.Bavisa@t-systems.com>
Matthieu Gallien [Mon, 13 Jan 2025 14:39:32 +0000 (15:39 +0100)]
Merge pull request #7749 from nextcloud/rakekniven-patch-1
chore(i18n): Improved grammar
rakekniven [Sun, 12 Jan 2025 17:34:47 +0000 (18:34 +0100)]
chore(i18n): Improved grammar
Reported on the forums
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Matthieu Gallien [Mon, 13 Jan 2025 09:46:27 +0000 (10:46 +0100)]
Merge pull request #7742 from nextcloud/tflidd-patch-1
Update macosvfs.rst
tflidd [Fri, 10 Jan 2025 09:11:47 +0000 (10:11 +0100)]
Update macosvfs.rst
Typo in the header
Signed-off-by: tflidd <tflidd@aspekte.net>
Nextcloud bot [Mon, 13 Jan 2025 02:56:11 +0000 (02:56 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 11 Jan 2025 02:56:02 +0000 (02:56 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Fri, 10 Jan 2025 18:10:42 +0000 (19:10 +0100)]
Merge pull request #7583 from nextcloud/bugfix/remove-bcc
gui/tray: Remove BasicComboBox QML component, prefer native component
Claudio Cambra [Thu, 28 Nov 2024 16:57:19 +0000 (00:57 +0800)]
Delete unused BasicComboBox component
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 28 Nov 2024 16:56:14 +0000 (00:56 +0800)]
Use standard ComboBox for user status selector
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Fri, 10 Jan 2025 17:17:10 +0000 (18:17 +0100)]
Merge pull request #7743 from nextcloud/improve-doc-generation-feedback
improve feedback from documentation generation workflow
Jyrki Gadinger [Fri, 10 Jan 2025 09:57:12 +0000 (10:57 +0100)]
improve feedback from documentation generation workflow
see also: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-a-warning-message
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Nextcloud bot [Thu, 9 Jan 2025 02:59:37 +0000 (02:59 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Wed, 8 Jan 2025 13:27:49 +0000 (14:27 +0100)]
Merge pull request #7730 from nextcloud/bugfix/close-opened-menus
Fix "open local or group folders" menu not showing
Jyrki Gadinger [Wed, 8 Jan 2025 09:55:47 +0000 (10:55 +0100)]
fix apps menu not closing when the window is hidden, and make group folders menu work again
this change resolves this ReferenceError when the window is being closed:
```
2025-01-08 10:56:40:389 [ warning default qrc:/qml/src/gui/tray/MainWindow.qml:100 ]: qrc:/qml/src/gui/tray/MainWindow.qml:100: ReferenceError: appsMenu is not defined
```
I also noticed that the "Open local or group folders" dropdown menu
wouldn't show up due to this error:
```
2025-01-08 10:56:23:327 [ warning default qrc:/qml/src/gui/tray/TrayFoldersMenuButton.qml:33 ]: qrc:/qml/src/gui/tray/TrayFoldersMenuButton.qml:33: Error: Cannot call method QQuickPopup::open on QQuickLoader_QML_48(0x5569fb4648d0)
```
--> wrapped the calls to the open/close methods in a closure
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Jyrki Gadinger [Wed, 8 Jan 2025 09:55:21 +0000 (10:55 +0100)]
remove old vim swap file
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Nextcloud bot [Wed, 8 Jan 2025 02:57:13 +0000 (02:57 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Tue, 7 Jan 2025 09:56:45 +0000 (10:56 +0100)]
Merge pull request #7725 from nextcloud/bugfix/tray-ui-colours
gui/tray: Fix colour for secondary text items being too pale
Claudio Cambra [Tue, 7 Jan 2025 05:55:49 +0000 (14:55 +0900)]
Use dark palette colour for secondary text
Improves readability in dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 7 Jan 2025 04:00:04 +0000 (13:00 +0900)]
Replace use of midlight palette colour for secondary text with mid colour
Improves visibility
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Tue, 7 Jan 2025 09:55:34 +0000 (10:55 +0100)]
Merge pull request #7720 from PatrickJosh/master
Make extraction of ETag header independent of capitalisation
Joshua Noeske [Sat, 4 Jan 2025 18:56:41 +0000 (19:56 +0100)]
Make extraction of ETag header independent of capitalisation.
Fixes #7703.
Signed-off-by: Joshua Noeske <git@joshuanoeske.de>
Matthieu Gallien [Tue, 7 Jan 2025 07:45:26 +0000 (08:45 +0100)]
Merge pull request #7724 from nextcloud/bugfix/ensureDbAccess
ensure proper read write access to root folder and db files
Matthieu Gallien [Mon, 6 Jan 2025 21:06:29 +0000 (22:06 +0100)]
ensure proper read write access to root folder and db files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Tue, 7 Jan 2025 02:55:34 +0000 (02:55 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 6 Jan 2025 10:00:01 +0000 (11:00 +0100)]
Merge pull request #7683 from kaikli/fix-dev-app-name
fix dev application name to keep a consitant migration behaviour for the dev and prod build
kaikli [Wed, 18 Dec 2024 06:33:00 +0000 (07:33 +0100)]
fix dev application name
keep application name and short name the same for the dev and prod build or some migration logic will work differently for each build
Signed-off-by: kaikli <75146125+kaikli@users.noreply.github.com>
Nextcloud bot [Mon, 6 Jan 2025 03:23:31 +0000 (03:23 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 5 Jan 2025 03:08:40 +0000 (03:08 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 4 Jan 2025 02:57:42 +0000 (02:57 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Fri, 3 Jan 2025 16:14:37 +0000 (17:14 +0100)]
Merge pull request #7713 from nextcloud/bugfix/doNotAlwaysFreeUpStorageWindowsShortcuts
Bugfix/do not always free up storage windows shortcuts